fix: draw classroom icons at the display's real pixel density
Icons went soft under UI_SCALE while the clock text beside them stayed sharp, which is visible on a 24" monitor even if it hides on a TV. new_from_file_at_scale rasterises an SVG at its *logical* size. The artwork is vector, but by the time sway scaled the session it was already a fixed raster, and the compositor enlarged that. Text never had the problem because GTK draws it at the real density. GTK 3 has no fractional scaling, so sway advertises the ceiling integer scale and scales the finished buffer down. Measured under sway: scale factor 1 at output scale 1.0, and 2 at 1.25, 1.5 and 2.0. So each icon is now rasterised at size x scale_factor physical pixels and handed to GTK as a cairo surface carrying that device scale. The icon lands at the real density; its logical size, and the whole dock layout, is unchanged. Icons redraw on notify::scale-factor as well as at realize, since the scale factor is not known until a widget is on a display and changes if UI_SCALE is changed under a running session. Browser, DVD, LIVE and all six DVD control icons go through it, in a shared module so the dock and the DVD session cannot diverge. The throbber is drawn rather than loaded and had the same flaw, so it draws on a device-scaled surface too rather than being the one soft thing left in a sharp dock. The artwork is untouched. Verified by rendering the dock under sway at 1.0, 1.25, 1.5 and 2.0 against the previous build: apparent icon size is identical at every scale (28, 35, 42, 56 px), 1.0 is unchanged pixel-for-pixel, and peak edge contrast on the Chrome icon goes from 60 to 99 at 1.25, 49 to 83 at 1.5, and 37 to 82 at 2.0 out of 255. The DVD control bar was checked the same way. Also records that Wonder Ink session-only cookies are confirmed working on the endpoint, which settles the question 0.1.34 shipped as unverified and tells us the session is in cookies rather than localStorage. Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5
parent
a0f2b74d05
commit
a1a218b29f
@@ -32,6 +32,10 @@ Change it, then `sudo systemctl restart getty@tty1`.
|
||||
- [ ] Chrome's buttons are still easy to hit with the mouse
|
||||
- [ ] Dock, clock, notifications and the DVD bar grow by the same
|
||||
amount — once, not twice
|
||||
- [ ] Dock icons stay crisp at 1.25 and 1.5 on a normal-density monitor,
|
||||
not just from across the room: compare an icon against the clock
|
||||
text beside it
|
||||
- [ ] DVD control bar icons are crisp at the same scales
|
||||
- [ ] `UI_SCALE=0.8` shrinks everything together
|
||||
- [ ] A nonsense value (`UI_SCALE=banana`) still gives a working shell
|
||||
- [ ] An extreme value (`UI_SCALE=9`) is clamped, not obeyed
|
||||
|
||||
Reference in New Issue
Block a user