fix: draw classroom icons at the display's real pixel density
Icons went soft under UI_SCALE while the clock text beside them stayed sharp, which is visible on a 24" monitor even if it hides on a TV. new_from_file_at_scale rasterises an SVG at its *logical* size. The artwork is vector, but by the time sway scaled the session it was already a fixed raster, and the compositor enlarged that. Text never had the problem because GTK draws it at the real density. GTK 3 has no fractional scaling, so sway advertises the ceiling integer scale and scales the finished buffer down. Measured under sway: scale factor 1 at output scale 1.0, and 2 at 1.25, 1.5 and 2.0. So each icon is now rasterised at size x scale_factor physical pixels and handed to GTK as a cairo surface carrying that device scale. The icon lands at the real density; its logical size, and the whole dock layout, is unchanged. Icons redraw on notify::scale-factor as well as at realize, since the scale factor is not known until a widget is on a display and changes if UI_SCALE is changed under a running session. Browser, DVD, LIVE and all six DVD control icons go through it, in a shared module so the dock and the DVD session cannot diverge. The throbber is drawn rather than loaded and had the same flaw, so it draws on a device-scaled surface too rather than being the one soft thing left in a sharp dock. The artwork is untouched. Verified by rendering the dock under sway at 1.0, 1.25, 1.5 and 2.0 against the previous build: apparent icon size is identical at every scale (28, 35, 42, 56 px), 1.0 is unchanged pixel-for-pixel, and peak edge contrast on the Chrome icon goes from 60 to 99 at 1.25, 49 to 83 at 1.5, and 37 to 82 at 2.0 out of 255. The DVD control bar was checked the same way. Also records that Wonder Ink session-only cookies are confirmed working on the endpoint, which settles the question 0.1.34 shipped as unverified and tells us the session is in cookies rather than localStorage. Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5
parent
a0f2b74d05
commit
a1a218b29f
@@ -81,6 +81,16 @@ integer scale of 2 to GTK, which renders at 2x, and sway scales the
|
||||
result down to 1.5x. The dock is the right size but very slightly softer
|
||||
than at 1.0. On a TV at classroom distance this is not visible.
|
||||
|
||||
Icons have to be drawn for that themselves. `new_from_file_at_scale`
|
||||
rasterises an SVG at its *logical* size, and the compositor then
|
||||
enlarges that finished raster — which made icons visibly soft on a 24"
|
||||
monitor while the clock text beside them stayed sharp. `classroom_icons`
|
||||
renders each SVG at `size x scale_factor` physical pixels and hands GTK
|
||||
a cairo surface carrying that device scale, so the artwork lands at the
|
||||
display's real density and the layout is unchanged. Measured on the
|
||||
Chrome icon, peak edge contrast at UI_SCALE 1.5 went from 49 to 83 out
|
||||
of 255, and at 2.0 from 37 to 82; at 1.0 it is identical to before.
|
||||
|
||||
**XWayland is softer at fractional scale.** X11 clients have no concept
|
||||
of a fractional output scale, so sway renders them at the logical size
|
||||
and scales the buffer. Measured on terminal text, scale 1.5 produced
|
||||
|
||||
Reference in New Issue
Block a user