fix: put the popup close button in the dock, and clear the printer location

Three things, none of them redesigns.

The close affordance for a secondary Chrome window was a separate
layer-shell surface anchored to that window's corner, repositioned by a
five-per-second poll. Any position change tore the surface down and
built another, so on real hardware it chased the window and flickered.
Removed entirely: the GTK button process, the geometry maths that placed
it, the --close-button mode that spawned it, and the poll loop that
drove it. The window helper no longer imports GTK at all.

The behaviour underneath it was right and is kept. The first Chrome
top-level is the classroom browser, tiled and borderless; later ones
float centred at about three quarters of the output. Creation order is
the only thing that can tell them apart — confirmed on a real session,
where every Chrome top-level shares app_id, shell, PID and a null
transient_for, and sway exposes no window properties for Wayland
toplevels at all. Titles are still not used. It now follows sway's own
window events instead of polling, so dragging a popup costs nothing.

Close moved into the dock, which was already on screen and does not
move, so it cannot chase anything. It appears only while a secondary
window is focused and runs kill on that one container. The helper
publishes which window that is; the dock watches the file rather than
polling. A stock sway title bar has no close button, so restoring the
border would not have solved this either.

Two bugs found by looking rather than by testing state. Chrome
renegotiates the size of a popup opened with explicit dimensions after
the resize returns, which left windows centred for a width they no
longer had; placement now settles and repeats once, at creation only, so
dragging is still free. And the dock's Close button came up empty
because show_all does not recurse into a no-show-all widget.

The printer's Location is now blank. CUPS prints it under the queue name
in every dialog, so "Ekklesia Classroom" was a second line the teacher
had to read past; the identity is one word. The already-configured check
includes Location, so a machine set up before this is corrected rather
than left as close enough.

Co-Authored-By: Claude Opus 5 <[email protected]>

tests/test-deployment-support.sh

@@ -15,6 +15,9 @@ postinst = (root / "packaging/debian/postinst").read_text()
 provision = (root / "scripts/classroom-provision").read_text()
 units = "\n".join(path.read_text() for path in (root / "systemd").rglob("*.service"))
 canary = (root / "update_canary.sh").read_text()
+validation_script = (root / "tools/validate-trixie-release.sh").read_text()
+sway = (root / "config/sway/config").read_text()
+build = (root / "tools/build-release.sh").read_text()
 policy = json.loads(
     (root / "config/chrome/policies/managed/ekklesia-classroom.json").read_text()
 )
@@ -56,12 +59,31 @@ print("3. printing service behavior")
 check("CUPS service and socket are enabled", "systemctl enable cups.socket cups.service || true" in postinst)
 check("CUPS start is best effort", "systemctl start cups.socket || true" in postinst)
 check("automatic remote queue browsing is disabled", "systemctl disable --now cups-browsed.service || true" in postinst)
-check("printer setup is never a boot service", "classroom-printer-setup" not in units)
-check("printer setup is never provisioning", "classroom-printer-setup" not in provision)
+check("Avahi service and socket are disabled", "systemctl disable --now avahi-daemon.socket avahi-daemon.service || true" in postinst)
+check("Avahi service and socket are masked", "systemctl mask avahi-daemon.socket avahi-daemon.service || true" in postinst)
+check("printer setup is not a blocking boot dependency", "classroom-printer-setup" not in units)
+check("printer setup runs automatically in provisioning", "/usr/local/bin/classroom-printer-setup" in provision)
+check("printer provisioning is bounded", "--kill-after=5s 30s" in provision)
 check("Chrome uses the system print dialog", policy.get("DisablePrintPreview") is True)
 
 print()
-print("4. canary release gate")
+print("4. secondary Chrome windows")
+check("stateful Chrome helper starts with Sway", "/usr/local/bin/classroom-chrome-windows" in sway)
+check("Chrome helper is packaged", '"$ROOT/scripts/classroom-chrome-windows"' in build)
+check("Chrome role module is packaged", '"$ROOT/lib/classroom_chrome.py"' in build)
+check("no broad Chrome floating rule", not any(
+    "google-chrome" in line and "floating enable" in line
+    for line in sway.splitlines()
+))
+
+print()
+print("5. bounded Trixie validation")
+check("container has an outer deadline", "720s" in validation_script)
+check("package installs have deadlines", "candidate-install 360" in validation_script)
+check("container service startup is suppressed", "/usr/sbin/policy-rc.d" in validation_script and "exit 101" in validation_script)
+
+print()
+print("6. canary release gate")
 validation = canary.index('"$ROOT/tools/validate-trixie-release.sh"')
 package_copy = canary.index('cp "$package_path"')
 first_rsync = canary.index("rsync -av")