Zayin/Classroom_Desktop
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: a machine with no ifupdown configuration is not an error

Browse Source 
The release validator caught it: in a container there is no
/etc/network/interfaces at all, and a missing file was being treated as
a read failure, so --check printed nothing and said nothing was wrong
rather than saying there was nothing to do.

A machine with no ifupdown configuration is the ordinary case for a
fresh install, and the answer is simply that this command has no work.

Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
ekklesia
2026-09-21 21:23:30 -05:00
co-authored by Claude Opus 5
parent b8688d00a7
commit fe08363534
3 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test-classroom-network-adopt.sh
+9 -1
View File
@@ -166,7 +166,15 @@ check("it refuses to start when it could not undo itself",
"shutil.which" in wifi
and "leaving the network exactly as it is" in wifi)
print("9. the upgrade does not do any of this on its own")
print("9. a machine with no ifupdown configuration at all")
# A container, and any machine installed without ifupdown. Found by the
# release validator: --check said nothing at all, because a missing file
# was being treated as a read error.
check("a missing interfaces file is not an error, it is just nothing to do",
"not os.path.exists(INTERFACES)" in wifi
and 'return None, ""' in wifi)
print("10. the upgrade does not do any of this on its own")
# Moving a machine's only link during an unattended upgrade is fine until
# the once it is not, and the machine it would strand is a laptop in a
# locked room.