fix: give Doctor the host configuration the runtime receives
`pnpm doctor` and `startApi` each read their own subset of the same environment variables, and the subsets had drifted. Doctor never read `S3_*` or module secrets at all, so a correctly configured installation was told its object storage was "not configured" and every module requiring a bucket or a secret was reported blocked -- while the runtime, from the identical environment, bound those buckets and ran the modules. Both executables now map the environment through one `loadHostConfiguration(env)` in Core, which takes the environment as an argument and never reads `process.env` itself. Validation stays with the existing per-domain validators, so each caller keeps its own failure behaviour: startup refuses a rejected value, Doctor reports it as a sanitized code. Doctor's storage option becomes raw input like its mail option, so a half-configured provider is reported as a blocking configuration failure instead of throwing before a report exists. The outbound-email check -- computed, counted toward the result, but absent from every rendered section -- is now printed, and the rendered set is asserted against a real report so a future check cannot go missing the same way. Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5
parent
a835215eb8
commit
2b4f0afb72
@@ -22,8 +22,22 @@ const sections: readonly DoctorSection[] = Object.freeze([
|
||||
section("PostgreSQL", ["database.transport", "postgresql.connection", "postgresql.plan"]),
|
||||
section("Identity", ["identity.configuration", "identity.client-address"]),
|
||||
section("Object storage", ["object-storage.integration", "object-storage.bindings"]),
|
||||
section("Outbound email", ["outbound-email.configuration"]),
|
||||
]);
|
||||
|
||||
/**
|
||||
* Every check id, exactly once.
|
||||
*
|
||||
* A check absent from `sections` is still computed and still counted toward the overall result, but
|
||||
* is never shown — so a configuration failure would flip an operator's report to NOT READY with
|
||||
* nothing on screen explaining why. `outbound-email.configuration` was in precisely that state, and
|
||||
* `doctor-report.test.ts` now compares this list against the ids of a real report, so a new check
|
||||
* cannot be added without being rendered.
|
||||
*/
|
||||
export const RENDERED_DOCTOR_CHECK_IDS: readonly DoctorCheckId[] = Object.freeze(
|
||||
sections.flatMap((entry) => [...entry.checkIds]),
|
||||
);
|
||||
|
||||
const statusSymbols: Readonly<Record<DoctorCheck["status"], string>> = Object.freeze({
|
||||
failure: "✗",
|
||||
pass: "✓",
|
||||
|
||||
Reference in New Issue
Block a user