Fix the Stage 1 Dashboard UX defects found in assembled review
CI / verify (pull_request) Successful in 1m13s
CI / infrastructure-smoke (pull_request) Successful in 34s
CI / package-release (pull_request) Successful in 48s
CI / migration-smoke (pull_request) Successful in 2m22s
CI / image-build (pull_request) Successful in 1m8s
CI / deploy-smoke (same-origin) (pull_request) Successful in 49s
CI / package-publication (pull_request) Successful in 57s
CI / deploy-smoke (split) (pull_request) Successful in 3m38s

The assembled Stage 1 Dashboard was reviewed by hand on a desktop, with
the sidebar collapsed, and on an iPhone. This fixes what that review
found, and records the decisions in ADR 0064:

- Discover is its own page at /settings/discover, with Installed and
  Updates beneath it as children. There is no Browse item any more.
  /settings/discover/browse is still read, as an alias, and is respelled
  in place. Parents and children now read as a hierarchy: a guide line,
  text-only children, a disclosure chevron, and parent and current
  states that look different.
- The sidebar is navigation only. Display pairing moves from the sidebar
  and drawer to Settings -> Displays: the paired displays, a deliberate
  Add display dialog, and revocation. Nothing takes focus on arrival;
  the code field is focused only once Add display is chosen.
- Collapsed icons are centred. Nav-link layout moves from inline styles
  to the shell stylesheet, and every collapsed item is one square
  centred on the rail.
- /settings is an overview of the installation: displays paired,
  modules installed and running, and a line for each other area. It
  reads only existing endpoints.
- Phones get a sticky, safe-area-aware header holding the menu trigger
  and the page name. New pages start at the top, and focus no longer
  scrolls content under the header.
- @ekklesia/ui draws checkbox and radio indicators from tokens rather
  than accent-color, so the selected state is the strong accent in
  Light and Dark alike.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
ekklesia
2026-10-15 20:37:32 -05:00
co-authored by Claude Opus 5.5
parent 186668915b
commit 405e509bcb
31 changed files with 2346 additions and 611 deletions
+22
View File
@@ -462,6 +462,28 @@ proven at each layer:
- The deploy smoke's real Chromium checks Light and Dark rendering, reload persistence, an emulated OS
change, reduced motion, a module's Shadow DOM following the theme, and phone width.
The Stage 1 review corrections
([ADR 0064](../architecture/decisions/0064-stage-1-shell-review-corrections.md)) are proven here:
- `surfaces/shell/tests/dashboard-routes.test.ts` reads Discover's own page at `/settings/discover`,
Installed and Updates beneath it, and `/settings/discover/browse` only as an alias that respells to
`/settings/discover`.
- `surfaces/shell/tests/settings-navigation.test.tsx` covers:
- the Settings overview's summaries, read only for what the person may see;
- Discover with no Browse child, its parent and child marking, and the collapsed rail showing
Discover alone;
- the alias respelled in place, keeping `?return=`;
- no display-pairing block in the sidebar or drawer, and no field focused on arrival;
- the collapsed geometry left to the stylesheet;
- the sticky phone header and the drawer opening from it.
- `surfaces/shell/tests/displays-settings.test.tsx` covers Settings → Displays: the list, empty and
refused states, the Add display flow focusing each next step, Cancel, and revocation behind a product
dialog.
- `packages/ui/tests/tokens.test.ts` holds the checkbox and radio indicators to tokens: never
`accent-color`, and the strong accent for the selected state.
- None of these defects showed until the product was assembled, so a change to the shell's layout
also gets a real-browser look at wide, collapsed, and phone widths in Light and Dark.
Unit suites (`core/tests/module-storage.test.ts`, `core/tests/module-storage-lifecycle.test.ts`) use an
injected in-memory provider and never touch the network. They prove the parts the protocol cannot:
binding determinism and collision-safety, scoping and cross-module isolation, key validation, lazy