fix: preserve authorization security history
Two security records did not survive user deletion, because both hung off a cascading foreign key to the live Better Auth user row. Deleting a user with authorization history deleted that history. A subject with a create and a revoke audit row had zero rows afterwards: the record of what they had been granted, by whom, and when it was revoked disappeared at exactly the moment it mattered most. `ekklesia_core_authorization_audit.subject_user_id` is now a retained, non-null historical snapshot with no foreign key — a plain identifier that may name a user row which no longer exists. No name, email, or other profile data is copied into authorization tables. The Drizzle relation to the user table is dropped too, because modelling a retained snapshot as a live relation misdescribes the data. Live rows still cascade, as intended: deleting a user removes their grants and platform-owner row, so nothing continues authorizing a principal that no longer exists. Platform-owner bootstrap's single use was equally fragile. "Already consumed" meant "a row exists in ekklesia_core_platform_owner", and that table cascades too — so deleting the bootstrapped owner's user row removed the owner row, its audit evidence, and with them the only thing preventing the operation that establishes a platform's first administrator from being run again. A dedicated `ekklesia_core_platform_owner_bootstrap` singleton now carries that authority. Its id is pinned by a check constraint to the literal 'singleton', so the primary key makes a second row structurally impossible rather than merely unwritten by convention; it has no user foreign key, and Core never deletes from it. Bootstrap claims that record inside the same transaction as the owner row and its audit entry, so consumption is tied to success: a missing target user or any other failure rolls the sentinel back and leaves the one legitimate first use available. The existing transaction-scoped advisory lock still serializes concurrent first attempts to exactly one success. The operational consequence is deliberate and permanent: deleting the last platform owner does not reactivate bootstrap, and neither does revoking one. Core migration 0002_authorization_integrity creates the singleton table, drops the cascading audit-subject constraint, and backfills consumed state for any installation that already holds a platform-owner row — active or revoked — so an existing deployment cannot gain a fresh first use by upgrading. It records no subject, because a backfill cannot know which of several historical owner rows the original use targeted and guessing would fabricate history. A never-owned installation is untouched and keeps its one first use. One upgrade limitation is irrecoverable and is documented rather than papered over: if an operator manually deleted the bootstrapped owner's user row before this migration, the old cascade already erased the owner row and its audit evidence, so nothing remains to detect. At this checkpoint no supported Better Auth or API user-deletion path can produce that state; it requires direct database access. Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
ekklesia
co-authored by
Claude Opus 5
Claude Opus 5
parent
6b6b77c105
commit
532ce3803b
@@ -3,12 +3,13 @@ import { mkdtemp, rm } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import path from "node:path";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { parseEkklesiaUserId } from "@ekklesia/contracts";
|
||||
import { createUserActor, parseEkklesiaUserId, parsePermissionId } from "@ekklesia/contracts";
|
||||
import { Client, type QueryResultRow } from "pg";
|
||||
import { afterAll, describe, expect, it } from "vitest";
|
||||
import {
|
||||
bootstrapPlatformOwner,
|
||||
createAuthorizationDrizzleDatabase,
|
||||
createAuthorizationStore,
|
||||
PlatformOwnerBootstrapError,
|
||||
} from "../src/authorization/index.js";
|
||||
import {
|
||||
@@ -255,7 +256,7 @@ describe.sequential("live platform-owner bootstrap", () => {
|
||||
expect(audit).toHaveLength(1);
|
||||
});
|
||||
|
||||
it("still refuses bootstrap after the existing owner is revoked — the historical row alone is enough to have consumed it", async () => {
|
||||
it("still refuses bootstrap after the existing owner is revoked — the durable consumed record, not the owner row, is the authority", async () => {
|
||||
await safeQuery(
|
||||
admin,
|
||||
`update "ekklesia_core_platform_owner" set revoked_at = now(), revoked_by_actor_type = 'system' where user_id = $1`,
|
||||
@@ -362,3 +363,328 @@ describe.sequential("live platform-owner bootstrap — concurrency", () => {
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
/**
|
||||
* Pass 3: bootstrap's single-use authority and authorization security history must both survive
|
||||
* user deletion, which is exactly what the pre-Pass-3 cascading foreign keys destroyed.
|
||||
*
|
||||
* The administrative client here is **test-only provisioning and inspection infrastructure**: it
|
||||
* seeds users, performs the user deletion under test, and reads back the resulting state. It is
|
||||
* never an API pool or a runtime connection, and every client and disposable database it opens is
|
||||
* closed or dropped in `finally`.
|
||||
*/
|
||||
describe.sequential("live platform-owner bootstrap — durability across user deletion", () => {
|
||||
async function consumedCount(client: Client): Promise<number> {
|
||||
const rows = await safeQuery<{ count: string }>(
|
||||
client,
|
||||
`select count(*)::text as count from "ekklesia_core_platform_owner_bootstrap"`,
|
||||
);
|
||||
return Number(rows[0]?.count ?? "0");
|
||||
}
|
||||
|
||||
it("records exactly one consumed row, one owner row, and one audit row in one transaction", async () => {
|
||||
const database = await createDisposableDatabase("durable");
|
||||
await applyCoreMigrations(database.url);
|
||||
const admin = await openAdministrativeClient(database.url);
|
||||
const { close, db } = createAuthorizationDrizzleDatabase(database.url);
|
||||
try {
|
||||
const ownerId = parseEkklesiaUserId("durable_owner");
|
||||
const laterId = parseEkklesiaUserId("durable_later");
|
||||
await seedUser(admin, ownerId, "[email protected]");
|
||||
await seedUser(admin, laterId, "[email protected]");
|
||||
|
||||
expect(await consumedCount(admin)).toBe(0);
|
||||
await bootstrapPlatformOwner(db, { userId: ownerId });
|
||||
|
||||
const consumed = await safeQuery<{ consumed_for_user_id: string | null; id: string }>(
|
||||
admin,
|
||||
`select id, consumed_for_user_id from "ekklesia_core_platform_owner_bootstrap"`,
|
||||
);
|
||||
expect(consumed).toHaveLength(1);
|
||||
expect(consumed[0]?.id).toBe("singleton");
|
||||
expect(consumed[0]?.consumed_for_user_id).toBe(ownerId);
|
||||
expect(await ownerRowCount(admin)).toBe(1);
|
||||
expect(
|
||||
await safeQuery(
|
||||
admin,
|
||||
`select id from "ekklesia_core_authorization_audit" where action = 'platform_owner.grant'`,
|
||||
),
|
||||
).toHaveLength(1);
|
||||
|
||||
// Deleting the bootstrapped owner's user row removes the *live* owner row, exactly as
|
||||
// before — but no longer the consumed sentinel or the security history describing it.
|
||||
await safeQuery(admin, `delete from "ekklesia_core_user" where id = $1`, [ownerId]);
|
||||
expect(await ownerRowCount(admin)).toBe(0);
|
||||
expect(await consumedCount(admin)).toBe(1);
|
||||
const survivingAudit = await safeQuery<{ action: string; subject_user_id: string }>(
|
||||
admin,
|
||||
`select action, subject_user_id from "ekklesia_core_authorization_audit"`,
|
||||
);
|
||||
expect(survivingAudit).toHaveLength(1);
|
||||
expect(survivingAudit[0]).toMatchObject({
|
||||
action: "platform_owner.grant",
|
||||
subject_user_id: ownerId,
|
||||
});
|
||||
|
||||
// And bootstrap is still consumed — the operation that establishes a platform's first
|
||||
// administrator cannot be reopened by deleting a user.
|
||||
let captured: unknown;
|
||||
try {
|
||||
await bootstrapPlatformOwner(db, { userId: laterId });
|
||||
} catch (error) {
|
||||
captured = error;
|
||||
}
|
||||
expect(captured).toMatchObject({ code: "PLATFORM_OWNER_BOOTSTRAP_ALREADY_CONSUMED" });
|
||||
expect(await ownerRowCount(admin)).toBe(0);
|
||||
} finally {
|
||||
await close();
|
||||
await safeEnd(admin);
|
||||
await dropDatabase(database.name);
|
||||
}
|
||||
});
|
||||
|
||||
it("retains a grant subject's create and revoke audit rows after that user is deleted", async () => {
|
||||
const database = await createDisposableDatabase("audit_survives");
|
||||
await applyCoreMigrations(database.url);
|
||||
const admin = await openAdministrativeClient(database.url);
|
||||
const { close, db } = createAuthorizationDrizzleDatabase(database.url);
|
||||
try {
|
||||
const subjectId = parseEkklesiaUserId("audit_subject");
|
||||
const managerId = parseEkklesiaUserId("audit_manager");
|
||||
await seedUser(admin, subjectId, "[email protected]");
|
||||
await seedUser(admin, managerId, "[email protected]");
|
||||
|
||||
const store = createAuthorizationStore(db);
|
||||
const grant = await store.createGrant({
|
||||
actor: createUserActor(managerId),
|
||||
permission: parsePermissionId("calendar.events.read"),
|
||||
sourceKind: "explicit",
|
||||
userId: subjectId,
|
||||
});
|
||||
await store.revokeGrant({ actor: createUserActor(managerId), grantId: grant.id });
|
||||
|
||||
const before = await safeQuery<{ action: string }>(
|
||||
admin,
|
||||
`select action from "ekklesia_core_authorization_audit" where subject_user_id = $1 order by created_at`,
|
||||
[subjectId],
|
||||
);
|
||||
expect(before.map((row) => row.action)).toEqual(["grant.create", "grant.revoke"]);
|
||||
|
||||
await safeQuery(admin, `delete from "ekklesia_core_user" where id = $1`, [subjectId]);
|
||||
|
||||
// The live grant row still cascades with the user, as intended — the security *history*
|
||||
// does not.
|
||||
expect(
|
||||
await safeQuery(admin, `select id from "ekklesia_core_grant" where user_id = $1`, [
|
||||
subjectId,
|
||||
]),
|
||||
).toHaveLength(0);
|
||||
const after = await safeQuery<{ action: string; subject_user_id: string }>(
|
||||
admin,
|
||||
`select action, subject_user_id from "ekklesia_core_authorization_audit" where subject_user_id = $1 order by created_at`,
|
||||
[subjectId],
|
||||
);
|
||||
expect(after.map((row) => row.action)).toEqual(["grant.create", "grant.revoke"]);
|
||||
// The retained subject is a plain identifier snapshot; no profile data was ever copied here.
|
||||
expect(Object.keys(after[0] as object).sort()).toEqual(["action", "subject_user_id"]);
|
||||
} finally {
|
||||
await close();
|
||||
await safeEnd(admin);
|
||||
await dropDatabase(database.name);
|
||||
}
|
||||
});
|
||||
|
||||
it("does not consume bootstrap when the transaction fails after the sentinel was claimed", async () => {
|
||||
const database = await createDisposableDatabase("failed_claim");
|
||||
await applyCoreMigrations(database.url);
|
||||
const admin = await openAdministrativeClient(database.url);
|
||||
const { close, db } = createAuthorizationDrizzleDatabase(database.url);
|
||||
try {
|
||||
const ownerId = parseEkklesiaUserId("failed_claim_owner");
|
||||
await seedUser(admin, ownerId, "[email protected]");
|
||||
|
||||
// A temporary trigger makes the audit insert — the last statement of the bootstrap
|
||||
// transaction, after the sentinel and owner row were already written — violate the audit
|
||||
// action CHECK constraint.
|
||||
await safeQuery(
|
||||
admin,
|
||||
`create function ekklesia_test_break_bootstrap() returns trigger as $$
|
||||
begin new.action := 'not.a.real.action'; return new; end;
|
||||
$$ language plpgsql`,
|
||||
);
|
||||
await safeQuery(
|
||||
admin,
|
||||
`create trigger ekklesia_test_break_bootstrap_trigger before insert on "ekklesia_core_authorization_audit"
|
||||
for each row execute function ekklesia_test_break_bootstrap()`,
|
||||
);
|
||||
try {
|
||||
let captured: unknown;
|
||||
try {
|
||||
await bootstrapPlatformOwner(db, { userId: ownerId });
|
||||
} catch (error) {
|
||||
captured = error;
|
||||
}
|
||||
expect(captured).toMatchObject({ code: "PLATFORM_OWNER_BOOTSTRAP_FAILED" });
|
||||
// The sentinel, the owner row, and the audit row all rolled back together, so the one
|
||||
// legitimate first use is still available.
|
||||
expect(await consumedCount(admin)).toBe(0);
|
||||
expect(await ownerRowCount(admin)).toBe(0);
|
||||
} finally {
|
||||
await safeQuery(
|
||||
admin,
|
||||
`drop trigger if exists ekklesia_test_break_bootstrap_trigger on "ekklesia_core_authorization_audit"`,
|
||||
);
|
||||
await safeQuery(admin, `drop function if exists ekklesia_test_break_bootstrap()`);
|
||||
}
|
||||
|
||||
// With the failure removed, bootstrap still works — it was never burned.
|
||||
await bootstrapPlatformOwner(db, { userId: ownerId });
|
||||
expect(await consumedCount(admin)).toBe(1);
|
||||
expect(await ownerRowCount(admin)).toBe(1);
|
||||
} finally {
|
||||
await close();
|
||||
await safeEnd(admin);
|
||||
await dropDatabase(database.name);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
/**
|
||||
* Upgrade path: an installation created before this migration must not gain a fresh first use.
|
||||
* These scenarios apply only 0000/0001, plant representative pre-migration state through the
|
||||
* test-only administrative client, then apply 0002 and assert the backfill's effect.
|
||||
*/
|
||||
describe.sequential("live Core migration 0002 — bootstrap-consumed backfill", () => {
|
||||
async function applyThrough(url: string, upTo: number): Promise<void> {
|
||||
const emptyModulesDirectory = await mkdtemp(
|
||||
path.join(tmpdir(), "ekklesia-upgrade-no-modules-"),
|
||||
);
|
||||
try {
|
||||
const aggregate = await discoverAllMigrations({
|
||||
coreMigrationsDirectory,
|
||||
moduleDiscovery: {
|
||||
moduleSdkVersion: "0.1.0",
|
||||
modulesDirectory: emptyModulesDirectory,
|
||||
platformVersion: "0.1.0",
|
||||
},
|
||||
});
|
||||
const selected = {
|
||||
...aggregate,
|
||||
migrations: aggregate.migrations.slice(0, upTo),
|
||||
};
|
||||
await applyModuleMigrations({
|
||||
aggregate: selected,
|
||||
database: createPostgresMigrationDatabase(url),
|
||||
});
|
||||
} finally {
|
||||
await rm(emptyModulesDirectory, { recursive: true, force: true });
|
||||
}
|
||||
}
|
||||
|
||||
async function consumedRows(client: Client) {
|
||||
return await safeQuery<{ consumed_for_user_id: string | null; id: string }>(
|
||||
client,
|
||||
`select id, consumed_for_user_id from "ekklesia_core_platform_owner_bootstrap"`,
|
||||
);
|
||||
}
|
||||
|
||||
it("backfills consumed state for an installation that already has an owner, including a revoked one", async () => {
|
||||
for (const [label, revoke] of [
|
||||
["active_owner", false],
|
||||
["revoked_owner", true],
|
||||
] as const) {
|
||||
const database = await createDisposableDatabase(label);
|
||||
const admin = await openAdministrativeClient(database.url);
|
||||
try {
|
||||
await applyThrough(database.url, 2);
|
||||
const ownerId = parseEkklesiaUserId(`upgrade_owner_${label}`);
|
||||
const nextId = parseEkklesiaUserId(`upgrade_next_${label}`);
|
||||
await seedUser(admin, ownerId, `upgrade-${label}@example.test`);
|
||||
await seedUser(admin, nextId, `upgrade-next-${label}@example.test`);
|
||||
await safeQuery(
|
||||
admin,
|
||||
`insert into "ekklesia_core_platform_owner" (user_id, granted_by_actor_type, granted_by_actor_id)
|
||||
values ($1, 'system', 'authorization-bootstrap-cli')`,
|
||||
[ownerId],
|
||||
);
|
||||
await safeQuery(
|
||||
admin,
|
||||
`insert into "ekklesia_core_authorization_audit" (action, actor_type, actor_id, subject_user_id)
|
||||
values ('platform_owner.grant', 'system', 'authorization-bootstrap-cli', $1)`,
|
||||
[ownerId],
|
||||
);
|
||||
if (revoke) {
|
||||
await safeQuery(
|
||||
admin,
|
||||
`update "ekklesia_core_platform_owner" set revoked_at = now(), revoked_by_actor_type = 'system' where user_id = $1`,
|
||||
[ownerId],
|
||||
);
|
||||
}
|
||||
|
||||
await applyThrough(database.url, 3);
|
||||
|
||||
const consumed = await consumedRows(admin);
|
||||
expect(consumed, label).toHaveLength(1);
|
||||
expect(consumed[0]?.id).toBe("singleton");
|
||||
// A backfill cannot know which of several historical owner rows the original single use
|
||||
// targeted, so it deliberately records no subject rather than fabricating one.
|
||||
expect(consumed[0]?.consumed_for_user_id).toBeNull();
|
||||
// Every pre-existing audit row survives the migration untouched.
|
||||
expect(
|
||||
await safeQuery(admin, `select id from "ekklesia_core_authorization_audit"`),
|
||||
).toHaveLength(1);
|
||||
|
||||
const { close, db } = createAuthorizationDrizzleDatabase(database.url);
|
||||
try {
|
||||
let captured: unknown;
|
||||
try {
|
||||
await bootstrapPlatformOwner(db, { userId: nextId });
|
||||
} catch (error) {
|
||||
captured = error;
|
||||
}
|
||||
expect(captured, label).toMatchObject({
|
||||
code: "PLATFORM_OWNER_BOOTSTRAP_ALREADY_CONSUMED",
|
||||
});
|
||||
} finally {
|
||||
await close();
|
||||
}
|
||||
} finally {
|
||||
await safeEnd(admin);
|
||||
await dropDatabase(database.name);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("leaves bootstrap available exactly once for an installation that never had an owner", async () => {
|
||||
const database = await createDisposableDatabase("never_owned");
|
||||
const admin = await openAdministrativeClient(database.url);
|
||||
try {
|
||||
await applyThrough(database.url, 2);
|
||||
const userId = parseEkklesiaUserId("never_owned_user");
|
||||
await seedUser(admin, userId, "[email protected]");
|
||||
|
||||
await applyThrough(database.url, 3);
|
||||
|
||||
// A legitimately never-bootstrapped installation must retain its one first use.
|
||||
expect(await consumedRows(admin)).toHaveLength(0);
|
||||
|
||||
const { close, db } = createAuthorizationDrizzleDatabase(database.url);
|
||||
try {
|
||||
await bootstrapPlatformOwner(db, { userId });
|
||||
expect(await consumedRows(admin)).toHaveLength(1);
|
||||
let captured: unknown;
|
||||
try {
|
||||
await bootstrapPlatformOwner(db, { userId });
|
||||
} catch (error) {
|
||||
captured = error;
|
||||
}
|
||||
expect(captured).toMatchObject({ code: "PLATFORM_OWNER_BOOTSTRAP_ALREADY_CONSUMED" });
|
||||
} finally {
|
||||
await close();
|
||||
}
|
||||
} finally {
|
||||
await safeEnd(admin);
|
||||
await dropDatabase(database.name);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user