feat(ui): shared confirmation, toasts, error, skeleton, and Back primitives
CI / verify (pull_request) Successful in 1m8s
CI / infrastructure-smoke (pull_request) Successful in 34s
CI / package-release (pull_request) Successful in 51s
CI / migration-smoke (pull_request) Successful in 2m27s
CI / image-build (pull_request) Successful in 1m6s
CI / deploy-smoke (same-origin) (pull_request) Successful in 50s
CI / package-publication (pull_request) Successful in 56s
CI / deploy-smoke (split) (pull_request) Successful in 2m44s

Stage 1's later screens and modules need the interactions DESIGN.md
fixes once for the product (ADR 0059). @ekklesia/ui gains them,
additively:

- ConfirmationDialog: simple, destructive, or typed-phrase
  confirmation, with severity chosen by the caller. Destructive is
  marked by symbol and frame, not colour alone, and starts on Cancel.
  A required phrase must match exactly (forgiving only surrounding
  whitespace and NFC). While busy, Cancel and Escape are disabled.
- ToastProvider / useToasts: a top-center toast system per React tree,
  never a package singleton (ADR 0040). Live regions are mounted
  before any toast arrives; errors are assertive and persist until
  dismissed; routine toasts last at least three seconds and longer for
  longer text. Timers pause on hover and focus; duplicates refresh;
  errors are never displaced; every timer is cleared on unmount.
- ErrorState: recovery actions, plus collapsed technical details and a
  reference, rendered as bounded inert text.
- Skeleton / SkeletonGroup: an aria-busy region labelled once, with
  every animation stopped under prefers-reduced-motion.
- PageHeader `back` (link or button) above the page's one h1.
- Dialog: the focus trap ADR 0039 deferred, plus focus restoration and
  an accessible description. Escape is now handled on the dialog
  itself, so a drawer it was opened from stays open.

The shell validates Back targets (parseReturnTarget, dashboardBack):
only a canonical Dashboard page on this origin is accepted, otherwise
Back goes to the page's parent. It never uses history.back().

Biome's scope-aware suspicious/noAlert is now an error in the root
biome.json. tests/native-dialogs.test.ts proves it catches real
dialogs and not lookalikes, and scans for the forms the rule misses.
It supersedes the shell-only regex test.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
ekklesia
2026-10-14 18:24:07 -05:00
co-authored by Claude Opus 5.5
parent 651efa8829
commit 5a7d44781b
23 changed files with 2538 additions and 59 deletions
+19
View File
@@ -0,0 +1,19 @@
// Nothing here is a browser dialog, and nothing here may be reported.
const confirm = (value: string): string => value;
confirm("a local function that happens to share the name");
function prompt(text: string): string {
return text;
}
prompt("a local declaration");
const dialog = { alert: () => 1, confirm: () => true, prompt: () => "" };
dialog.confirm();
dialog.alert();
dialog.prompt();
const props = { onConfirm: () => undefined };
props.onConfirm();
const confirmLabel = "Delete display";
const message = "Call alert( only in a string";
const pattern = /window\.confirm/u;
// window.confirm("a comment is not code");
/* alert("nor is a block comment"); */
export { confirmLabel, message, pattern };
@@ -0,0 +1,4 @@
// Forms Biome's call-based rule does not see; the repository scan must refuse each one.
self.prompt("a");
const borrowed = window.confirm;
export { borrowed };
+9
View File
@@ -0,0 +1,9 @@
// Every line below is a browser-native dialog. The repository's lint must refuse each one.
alert("a");
window.alert("b");
confirm("c");
window.confirm("d");
prompt("e");
window.prompt("f");
globalThis.confirm("g");
window["alert"]("h");