fix: enforce production transport policy
Every PostgreSQL connection this repository opened was plaintext, in every environment: no connection site set `ssl` at all, so credentials, session tokens, and row data crossed the network in the clear and nothing in configuration, startup, or `pnpm doctor` said so. The public identity URL boundary was also looser than it appeared. `core/src/database/transport.ts` is now the one typed policy. It has exactly two modes: `verify-full` (TLS required, certificate chain verified, and server identity verified against the configured host — the production default) and `disable` (the development/test default, refused outright in production). There is deliberately no encryption-only `require` mode, no chain-only `verify-ca`, and no `rejectUnauthorized: false` escape hatch anywhere in the configuration surface; every loose or aliased spelling is rejected in both environments, so a typo never quietly becomes a weaker mode. Production has no plaintext exception at all, not even for a loopback database — a connection string cannot prove the database is process-local. Verification is certificate *and* hostname. The policy supplies an explicit `checkServerIdentity` pinned to the host parsed from DATABASE_URL, because the pinned driver sets TLS `servername` only for non-IP hosts and Node performs no identity check when it is unset — so `rejectUnauthorized: true` alone accepts a certificate from any host the trusted CA ever signed when connecting by IP. Both halves are proven against a real TLS-enabled PostgreSQL, including that the same connection without the pinned callback succeeds. Every CA, certificate, and key is generated at test runtime and deleted afterwards. A DATABASE_URL may no longer carry its own TLS parameters. The pinned driver merges parsed connection-string values over explicitly passed options, so a `?sslmode=disable` in the URL would silently replace the policy's verified `ssl` object; that now fails with a stable code, reported by both `pnpm doctor` and the migration CLIs rather than as "failed unexpectedly". One shared environment reader keeps `process.env` out of Core's reusable constructors, and every executable that opens a connection resolves the policy identically: the API (validated before any pool, Better Auth instance, module runtime, or listener exists), both migration commands, the bootstrap CLI, and Doctor's own connection. Doctor reports it as a blocking failure, never a warning, naming only the effective mode. Separately, the identity base URL and every trusted origin must now be exactly one canonical origin — the WHATWG origin serialization must equal the supplied string — so a path, trailing slash, credentials, explicit default port, or non-canonical case is rejected rather than normalized into something that no longer matches what a browser sends. Production's loopback rejection now classifies the address instead of comparing against three literals, covering `.localhost`, all of 127.0.0.0/8, 0.0.0.0, `::`, expanded and IPv4-mapped forms. This is a configuration-shape guarantee only: it does not resolve DNS or prove reachability, and TLS protects the connection, not the exposure. Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5
parent
7a0f624fc3
commit
6b6b77c105
@@ -347,14 +347,20 @@ async function startConfiguredApi(
|
||||
options: StartConfiguredApiOptions = {},
|
||||
): Promise<RunningApi> {
|
||||
const publicSignupEnabled = options.publicSignupEnabled ?? true;
|
||||
// Production configuration refuses to enable public signup at all until durable abuse controls
|
||||
// exist (`PUBLIC_SIGNUP_UNSUPPORTED_IN_PRODUCTION`, `core/src/identity/config.ts`), so a scenario
|
||||
// that creates accounts over HTTP must validate its configuration as development — the explicit,
|
||||
// intended way to opt in. This changes only Ekklesia's own config-validation strictness:
|
||||
// `environment` never reaches Better Auth, and this harness keeps the identical https,
|
||||
// non-loopback base URL and trusted origins either way, so the production-equivalent origin/CSRF
|
||||
// behavior ADR 0012 established is exercised exactly the same in both cases.
|
||||
const environment = publicSignupEnabled ? "development" : "production";
|
||||
// This harness explicitly selects development configuration, for two independent reasons that
|
||||
// both apply to every scenario in this suite:
|
||||
//
|
||||
// 1. It connects to the disposable *plaintext* loopback PostgreSQL. Production configuration
|
||||
// requires certificate-verified TLS with no exception, so a plaintext test database can
|
||||
// only be used by a deployment that has explicitly declared itself non-production.
|
||||
// 2. Scenarios that create accounts over HTTP need public signup, which production refuses to
|
||||
// enable at all until durable abuse controls exist.
|
||||
//
|
||||
// This changes only Ekklesia's own configuration-validation strictness — `environment` never
|
||||
// reaches Better Auth — and the harness keeps the identical https, non-loopback base URL and
|
||||
// trusted origins regardless, so the production-equivalent origin/CSRF behavior ADR 0012
|
||||
// established is exercised exactly the same either way.
|
||||
const environment = "development" as const;
|
||||
const config = createApiRuntimeConfig(
|
||||
{
|
||||
...(options.clientAddress === undefined ? {} : { clientAddress: options.clientAddress }),
|
||||
@@ -2255,7 +2261,10 @@ describe.sequential("live API — Node header/request timeouts and client errors
|
||||
},
|
||||
port: 0,
|
||||
},
|
||||
{ environment: "production" },
|
||||
// Development configuration, for the same reason `startConfiguredApi` documents: this suite
|
||||
// connects to the disposable plaintext loopback PostgreSQL, which production configuration
|
||||
// never permits. Nothing about the transport-level timeout behavior under test depends on it.
|
||||
{ environment: "development" },
|
||||
);
|
||||
// Deliberately tiny, test-only timeouts — production composition (server.ts's `main`) never
|
||||
// sets this override — so a real timeout is observed deterministically in well under a second
|
||||
|
||||
Reference in New Issue
Block a user