Zayin/Ekklesia
3
0
Fork 0
Code Issues 6 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Make the module navigation capability an optional context member
CI / verify (pull_request) Successful in 1m11s
Details
CI / infrastructure-smoke (pull_request) Successful in 42s
Details
CI / package-release (pull_request) Successful in 48s
Details
CI / migration-smoke (pull_request) Successful in 2m27s
Details
CI / image-build (pull_request) Successful in 1m8s
Details
CI / deploy-smoke (same-origin) (pull_request) Successful in 52s
Details
CI / package-publication (pull_request) Successful in 57s
Details
CI / deploy-smoke (split) (pull_request) Successful in 3m35s
Details

Browse Source 
ModuleUiHostContext.navigation is now `navigation?: ModuleUiNavigation |
undefined`, so the public context change is source-compatible: a context built
before navigation existed (without the member) still compiles unchanged, as
0.x patch releases require. The Dashboard supplies navigation; hosts without
addressable pages, including the display host, omit the member; modules
feature-detect it. Existing hosts' tests are restored to their pre-PR shape,
and a module-ui-sdk test proves a pre-navigation context still satisfies
ModuleUiHostContext (and fails if the member is ever made required).
Runtime behaviour, manifest v8/v9 compatibility, and security rules are
unchanged. ADR 0063 and the module development guide say so.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
ekklesia
2026-10-15 09:13:03 -05:00
co-authored by Claude Opus 5.5
parent ae360ef318
commit c78f1318b4
13 changed files with 60 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
surfaces/shell/tests/display-app.test.tsx
+2 -3
View File
@@ -251,13 +251,12 @@ describe("display host — full-viewport boundary", () => {
"contributions",
"display",
"moduleId",
"navigation",
"permissions",
"principal",
"realtime",
]);
// A display is one screen with no pages: the display host offers no navigation (ADR 0063).
expect(seenContext?.navigation).toBeUndefined();
// A display is one screen with no pages: the display host omits navigation (ADR 0063).
expect(seenContext && "navigation" in seenContext).toBe(false);
expect(seenContext?.principal).toEqual({ kind: "authenticated", userId: "user-1" });
expect(isolatedText(query("display-module-container"))).toBe("permitted");
expect(