Add the account area and account-synced Appearance preferences
CI / verify (pull_request) Successful in 1m10s
CI / infrastructure-smoke (pull_request) Successful in 34s
CI / package-release (pull_request) Successful in 50s
CI / migration-smoke (pull_request) Successful in 2m26s
CI / image-build (pull_request) Successful in 1m12s
CI / deploy-smoke (same-origin) (pull_request) Successful in 42s
CI / package-publication (pull_request) Successful in 54s
CI / deploy-smoke (split) (pull_request) Successful in 3m17s
CI / verify (pull_request) Successful in 1m10s
CI / infrastructure-smoke (pull_request) Successful in 34s
CI / package-release (pull_request) Successful in 50s
CI / migration-smoke (pull_request) Successful in 2m26s
CI / image-build (pull_request) Successful in 1m12s
CI / deploy-smoke (same-origin) (pull_request) Successful in 42s
CI / package-publication (pull_request) Successful in 54s
CI / deploy-smoke (split) (pull_request) Successful in 3m17s
Stage 1 PR 6 (ADR 0062). /account shows who is signed in; /account/appearance chooses System, Light, or Dark and reduced motion (System, Reduce, Allow). - Core: ekklesia_core_user_preference, one typed, CHECK-constrained, nullable column per preference (null = never chosen), migration 0008_user_preferences (additive), @ekklesia/core/account store, and the authenticated-baseline permission core.account.self.manage. - API: GET /api/v1/account (name, email, preferences) and partial PATCH /api/v1/account/preferences, self-only by construction: no user id is accepted anywhere; trusted Origin and body limit on the mutation. - Shell: the account control shows name, email, and initials (never the unvetted image URL) and offers Account, Appearance, Sign out; native radio groups apply a choice at once through the ADR 0060 controller and save it; the server's answer wins and a failed save reverts. - First paint: a classic, same-origin, render-blocking appearance.js in <head> applies a two-word localStorage cache before paint (no inline script, CSP unchanged). The account replaces the cache on every load, sign-out clears it, and other tabs follow via the storage event. - Deploy smoke: real-Chromium checks for light/dark, OS emulation, overrides, reload persistence, pre-paint, Shadow DOM modules, reduced motion, the display staying light, and phone width; the browser container gets a 512 MiB /dev/shm so a long session no longer fails requests with ERR_INSUFFICIENT_RESOURCES. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
8571e6854c
commit
cd0287537e
@@ -0,0 +1,114 @@
|
||||
import type { EkklesiaAppearance, EkklesiaMotionPreference } from "@ekklesia/design-tokens";
|
||||
|
||||
/**
|
||||
* This browser's copy of the signed-in person's appearance and motion (ADR 0062).
|
||||
*
|
||||
* **A cache, never the source of truth.** The person's account holds their preferences, and every
|
||||
* Dashboard load replaces this copy with what the account says. The copy exists for one reason:
|
||||
* the account is only known once the API has answered, and by then the page has painted. The
|
||||
* Dashboard's pre-paint script (`appearance-boot.ts`) reads it synchronously, before the body is
|
||||
* parsed, so someone who chose Dark does not see a light page first.
|
||||
*
|
||||
* It holds two words — the appearance and the motion preference — under one namespaced key. No
|
||||
* name, email, user id, or anything else about the account: it is safe for anyone with access to
|
||||
* this browser profile to read, and it is cleared on sign-out so the next person starts from the
|
||||
* system's setting.
|
||||
*
|
||||
* This file is imported by the pre-paint script, so it imports only types: the script must stay
|
||||
* tiny and must not pull the token package into a render-blocking request.
|
||||
*/
|
||||
|
||||
export interface AppearanceChoice {
|
||||
readonly appearance: EkklesiaAppearance;
|
||||
readonly motion: EkklesiaMotionPreference;
|
||||
}
|
||||
|
||||
/** One namespaced key, beside the sidebar's (`ekklesia.dashboard.sidebar`). */
|
||||
export const APPEARANCE_CACHE_KEY = "ekklesia.dashboard.appearance";
|
||||
|
||||
// Repeated rather than imported from the token package, to keep the pre-paint script small; the
|
||||
// shell's tests hold both lists equal to `EKKLESIA_APPEARANCES` and `EKKLESIA_MOTION_PREFERENCES`.
|
||||
const APPEARANCES: readonly string[] = ["system", "light", "dark"];
|
||||
const MOTION_PREFERENCES: readonly string[] = ["system", "reduce", "allow"];
|
||||
|
||||
/** The serialized form: `<appearance> <motion>`, for example `dark reduce`. */
|
||||
export function serializeAppearanceChoice(choice: AppearanceChoice): string {
|
||||
return `${choice.appearance} ${choice.motion}`;
|
||||
}
|
||||
|
||||
/** Strict: exactly two known words. Anything else — including an older or tampered value — is no
|
||||
* cache at all, and the page follows the system until the account answers. */
|
||||
export function parseAppearanceCache(value: unknown): AppearanceChoice | undefined {
|
||||
if (typeof value !== "string") {
|
||||
return undefined;
|
||||
}
|
||||
const parts = value.split(" ");
|
||||
const [appearance, motion] = parts;
|
||||
if (
|
||||
parts.length !== 2 ||
|
||||
appearance === undefined ||
|
||||
motion === undefined ||
|
||||
!APPEARANCES.includes(appearance) ||
|
||||
!MOTION_PREFERENCES.includes(motion)
|
||||
) {
|
||||
return undefined;
|
||||
}
|
||||
return {
|
||||
appearance: appearance as EkklesiaAppearance,
|
||||
motion: motion as EkklesiaMotionPreference,
|
||||
};
|
||||
}
|
||||
|
||||
export interface AppearanceCache {
|
||||
read(): AppearanceChoice | undefined;
|
||||
write(choice: AppearanceChoice): void;
|
||||
clear(): void;
|
||||
}
|
||||
|
||||
/**
|
||||
* The browser's `localStorage`, handed in by the entry point. Exactly like the sidebar preference,
|
||||
* every access is guarded: storage can be missing, blocked, or full, and losing the cache only
|
||||
* costs the pre-paint hint, never the preference itself.
|
||||
*/
|
||||
export function createLocalAppearanceCache(
|
||||
storage: Pick<Storage, "getItem" | "setItem" | "removeItem"> | undefined,
|
||||
): AppearanceCache {
|
||||
return {
|
||||
clear() {
|
||||
try {
|
||||
storage?.removeItem(APPEARANCE_CACHE_KEY);
|
||||
} catch {
|
||||
// Nothing to undo: an unreadable cache is already no cache.
|
||||
}
|
||||
},
|
||||
read() {
|
||||
try {
|
||||
return parseAppearanceCache(storage?.getItem(APPEARANCE_CACHE_KEY));
|
||||
} catch {
|
||||
return undefined;
|
||||
}
|
||||
},
|
||||
write(choice) {
|
||||
const serialized = serializeAppearanceChoice(choice);
|
||||
try {
|
||||
storage?.setItem(APPEARANCE_CACHE_KEY, serialized);
|
||||
} catch {
|
||||
// The account still holds the preference; only the pre-paint hint is lost.
|
||||
}
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
/** Nothing persisted: for tests, and for a host composed without browser storage. */
|
||||
export function createMemoryAppearanceCache(initial?: AppearanceChoice): AppearanceCache {
|
||||
let choice = initial;
|
||||
return {
|
||||
clear() {
|
||||
choice = undefined;
|
||||
},
|
||||
read: () => choice,
|
||||
write(next) {
|
||||
choice = next;
|
||||
},
|
||||
};
|
||||
}
|
||||
Reference in New Issue
Block a user