Zayin/Ekklesia
3
0
Fork 0
Code Issues 1 Pull Requests 3 Actions Packages Projects Releases 8 Wiki Activity

fix(packages): declare runtime imports as production dependencies #47

Merged
Zayin_Admin merged 1 commits from fix/module-sdk-runtime-dependencies into main 2026-10-02 00:58:38 +00:00
Conversation 0 Commits 1 Files Changed 23
+322 -13
Zayin_Admin commented 2026-10-02 00:39:15 +00:00
Owner
Copy Link
Copy Source

@ekklesia/module-sdk imports drizzle-orm at run time but declared it
only as a peer and a development dependency. A workspace package is
linked into its consumers as a directory, so its imports resolve from
its own node_modules, where a consumer never satisfies a peer; a
production install omits development dependencies. In the production
image this made every module with a schema fail: the API exited at
startup and Doctor reported NOT READY.

  • Move drizzle-orm to module-sdk's dependencies, keeping the peer.
  • Move react to @ekklesia/ui's dependencies, keeping the peer. The new
    guard flags it the same way; it is bundled at build time today, so
    it was not a live failure. Both lockfile entries keep the identical
    resolution, so nothing new is installed and the shell bundles still
    contain one React.
  • Add the boundary rule runtime-imports-are-production-dependencies:
    code a package ships (src/, bin/, excluding tests and .d.ts) must
    declare every runtime import in dependencies or optionalDependencies.
    Type-only imports are exempt; .tsx/.jsx implies react (automatic
    JSX runtime). Fixtures cover peer-only, dev-only, JSX, undeclared,
    and the accepted cases.

Co-Authored-By: Claude Opus 5.5 [email protected]

@ekklesia/module-sdk imports drizzle-orm at run time but declared it only as a peer and a development dependency. A workspace package is linked into its consumers as a directory, so its imports resolve from its own node_modules, where a consumer never satisfies a peer; a production install omits development dependencies. In the production image this made every module with a schema fail: the API exited at startup and Doctor reported NOT READY. - Move drizzle-orm to module-sdk's dependencies, keeping the peer. - Move react to @ekklesia/ui's dependencies, keeping the peer. The new guard flags it the same way; it is bundled at build time today, so it was not a live failure. Both lockfile entries keep the identical resolution, so nothing new is installed and the shell bundles still contain one React. - Add the boundary rule runtime-imports-are-production-dependencies: code a package ships (src/, bin/, excluding tests and .d.ts) must declare every runtime import in dependencies or optionalDependencies. Type-only imports are exempt; .tsx/.jsx implies react (automatic JSX runtime). Fixtures cover peer-only, dev-only, JSX, undeclared, and the accepted cases. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Zayin_Admin added 1 commit 2026-10-02 00:39:15 +00:00
fix(packages): declare runtime imports as production dependencies
CI / verify (pull_request) Successful in 47s
Details
CI / infrastructure-smoke (pull_request) Successful in 21s
Details
CI / migration-smoke (pull_request) Successful in 1m45s
Details
fc422b6d8d 
@ekklesia/module-sdk imports drizzle-orm at run time but declared it
only as a peer and a development dependency. A workspace package is
linked into its consumers as a directory, so its imports resolve from
its own node_modules, where a consumer never satisfies a peer; a
production install omits development dependencies. In the production
image this made every module with a schema fail: the API exited at
startup and Doctor reported NOT READY.

- Move drizzle-orm to module-sdk's dependencies, keeping the peer.
- Move react to @ekklesia/ui's dependencies, keeping the peer. The new
  guard flags it the same way; it is bundled at build time today, so
  it was not a live failure. Both lockfile entries keep the identical
  resolution, so nothing new is installed and the shell bundles still
  contain one React.
- Add the boundary rule runtime-imports-are-production-dependencies:
  code a package ships (src/, bin/, excluding tests and .d.ts) must
  declare every runtime import in dependencies or optionalDependencies.
  Type-only imports are exempt; .tsx/.jsx implies react (automatic
  JSX runtime). Fixtures cover peer-only, dev-only, JSX, undeclared,
  and the accepted cases.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Zayin_Admin merged commit ef1383d080 into main 2026-10-02 00:58:38 +00:00
Zayin_Admin deleted branch fix/module-sdk-runtime-dependencies 2026-10-02 00:58:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Joey Zayin_Admin ekklesia-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Zayin/Ekklesia#47