ekklesiaandClaude Opus 5
bd34c9c714
Phase 6D pass 1. The shell's navigation was a flat list of module ids, which is not a usable experience — and the obvious fix carries an obvious trap. Letting a module declare its folder, or modelling "Media" as something Livestream and Video belong to, turns a rendering preference into architecture: a folder becomes an owner, membership starts to look like a dependency, and the flat module graph acquires a hierarchy nobody decided on. So the rule comes first: a Dashboard group is a label on a rendering bucket. No manifest, no version, no artifact, no API, no lifecycle; nothing depends on it. Livestream depends on Video because it calls Video's functionality, and that orders startup. Livestream is shown under Media, and that orders nothing. No parent module, child module, owning module, or group-derived dependency appears anywhere in the contracts. No manifest change and no version 5. `manifest.name` has been required since version 1 and already is the module's product identity, so the shell renders "Livestream" instead of `livestream` with nothing added. `suggestedGroup` is deliberately deferred rather than shipped: it would force a hard manifest-version cutover for a hint, and its only correct semantics needs initialization logic that risks a suggestion overwriting an administrator's decision. Defaulting and ownership are different things. Two Core tables (migration 0003) hold groups and placements — server-side, because a church configures its Dashboard rather than one browser; platform-global, because no organization model exists to scope them to. `group_id` is `on delete set null`, so deleting a group ungroups its modules and a dangling reference is impossible. `module_id` carries no foreign key, because modules are packages rather than rows, so a placement for an uninstalled module is retained and restores its position on reinstall. `resolveDashboardNavigation` is a pure function of configuration plus the mountable set: an unplaced module is ungrouped and visible with no initialization write, an absent module renders nothing, empty groups are kept, and ordering is total with the module id as final tie-break. `GET /api/v1/dashboard/navigation` returns the resolved view, layered on top of the host-neutral module UI inventory rather than merged into it — each generic descriptor is embedded untouched, so a standalone host never inherits Dashboard semantics. Reading needs the permission the inventory already needs; organizing needs the new platform permission `core.dashboard.navigation.manage` through a narrow, idempotent, closed-validation mutation contract. No editor UI. The flatness rule is executable: a test discovers real fixtures with a genuine dependency, arranges them four ways including both in one folder and the dependency inverted in presentation, and asserts discovery order, dependency declarations, and the module set stay byte-identical. The end-to-end test organizes a real installation through the real API, mounts a module from inside a group, moves it, and asserts the navigation entry is byte-identical across the move and still mounts the same artifact. The shell's client for the generic inventory became dead code and was removed rather than kept speculatively; the endpoint itself is unchanged. Co-Authored-By: Claude Opus 5 <[email protected]>
87 lines
3.2 KiB
TypeScript
87 lines
3.2 KiB
TypeScript
import type {
|
|
DashboardConfiguration,
|
|
DashboardGroupRecord,
|
|
DashboardPlacementRecord,
|
|
DashboardStore,
|
|
SetDashboardPlacementInput,
|
|
UpsertDashboardGroupInput,
|
|
} from "@ekklesia/core/dashboard";
|
|
import { DashboardStoreError } from "@ekklesia/core/dashboard";
|
|
|
|
/**
|
|
* An in-memory `DashboardStore` for tests that exercise **routing and resolution**, not persistence.
|
|
*
|
|
* It reproduces only the two behaviours those tests depend on — a placement may not name a group
|
|
* that does not exist, and deleting a group ungroups its modules (the schema's
|
|
* `on delete set null`) — and deliberately reproduces nothing else. Everything the real store owns
|
|
* that this double would only be guessing at (identifier grammar, label trimming and bounds,
|
|
* ordering bounds, transactional behaviour, and the actual `on delete set null` constraint) is
|
|
* proven against real PostgreSQL in `core/tests/dashboard-store.integration.ts` instead, so this
|
|
* double can never quietly stand in for a persistence guarantee nobody checked.
|
|
*/
|
|
export function createInMemoryDashboardStore(
|
|
seed: Partial<DashboardConfiguration> = {},
|
|
): DashboardStore {
|
|
const groups = new Map<string, DashboardGroupRecord>(
|
|
(seed.groups ?? []).map((group) => [group.id, { ...group }] as const),
|
|
);
|
|
const placements = new Map<string, DashboardPlacementRecord>(
|
|
(seed.placements ?? []).map((placement) => [placement.moduleId, { ...placement }] as const),
|
|
);
|
|
|
|
const sorted = <Record extends { readonly sortOrder: number }>(
|
|
records: readonly Record[],
|
|
key: (record: Record) => string,
|
|
): readonly Record[] =>
|
|
Object.freeze(
|
|
[...records].sort(
|
|
(left, right) =>
|
|
left.sortOrder - right.sortOrder ||
|
|
(key(left) < key(right) ? -1 : key(left) > key(right) ? 1 : 0),
|
|
),
|
|
);
|
|
|
|
return Object.freeze({
|
|
async deleteGroup(groupId: string): Promise<void> {
|
|
if (!groups.delete(groupId)) {
|
|
throw new DashboardStoreError("DASHBOARD_GROUP_NOT_FOUND");
|
|
}
|
|
for (const [moduleId, placement] of placements) {
|
|
if (placement.groupId === groupId) {
|
|
placements.set(moduleId, { ...placement, groupId: null });
|
|
}
|
|
}
|
|
},
|
|
|
|
async readConfiguration(): Promise<DashboardConfiguration> {
|
|
return Object.freeze({
|
|
groups: sorted([...groups.values()], (group) => group.id),
|
|
placements: sorted([...placements.values()], (placement) => placement.moduleId),
|
|
});
|
|
},
|
|
|
|
async setPlacement(input: SetDashboardPlacementInput): Promise<DashboardPlacementRecord> {
|
|
if (input.groupId !== null && !groups.has(input.groupId)) {
|
|
throw new DashboardStoreError("DASHBOARD_GROUP_NOT_FOUND");
|
|
}
|
|
const record: DashboardPlacementRecord = Object.freeze({
|
|
groupId: input.groupId,
|
|
moduleId: input.moduleId,
|
|
sortOrder: input.sortOrder,
|
|
});
|
|
placements.set(input.moduleId, record);
|
|
return record;
|
|
},
|
|
|
|
async upsertGroup(input: UpsertDashboardGroupInput): Promise<DashboardGroupRecord> {
|
|
const record: DashboardGroupRecord = Object.freeze({
|
|
id: input.id,
|
|
label: input.label.trim(),
|
|
sortOrder: input.sortOrder,
|
|
});
|
|
groups.set(input.id, record);
|
|
return record;
|
|
},
|
|
});
|
|
}
|