Files
Ekklesia/core/tests/doctor-report.test.ts
T
ekklesia edd7148aa8 feat: integrate module authorization
Wires composePlatformPermissionRegistry into apps/api's production
startup: startApi() discovers every installed module, composes the one
immutable platform permission registry (Core's own declarations plus
every module's), and only then constructs the shared PostgreSQL pool,
Better Auth, and the HTTP server. A discovery or composition failure —
an invalid manifest, a reserved core.* namespace claim, or a duplicate
declaration — propagates before anything exists to close; there is no
Core-only registry fallback. apps/api/src/platform-permissions.ts
resolves the repository root from its own file location, never
process.cwd(), so package-scoped test runs discover the right modules/
directory.

createApiApp/createGrantsRoutes now require the composed registry as
an injected authorization option, replacing the previous hard-coded
CORE_PERMISSION_REGISTRY; requirePermission continues to work
identically for Core-owned and module-owned permissions, since it has
no concept of the distinction.

Extends pnpm doctor with a modules.permissions check (reusing the
already-discovered module list, distinguishing reserved-namespace from
generic-duplicate failures, never re-discovering modules) and pnpm
modules:validate to compose the same registry before a module is
considered installable.

Adds focused coverage: startup-ordering and failure-isolation tests in
apps/api/tests/lifecycle.test.ts, module-owned-declaration enforcement
tests in apps/api/tests/authorization-middleware.test.ts, Doctor
composition tests in core/tests/doctor.test.ts, and a live PostgreSQL
end-to-end scenario proving a real installed module's permission is
discoverable, grantable, and deniable once the module is absent again
after a restart, without ever executing its server entrypoint.
2026-07-24 14:24:50 -05:00

183 lines
5.6 KiB
TypeScript

import { afterEach, describe, expect, it } from "vitest";
import {
type DoctorDependencies,
diagnoseEkklesia,
formatDoctorReport,
} from "../src/diagnostics/index.js";
import type { MigrationDatabase } from "../src/migrations/index.js";
import type { ModuleMigrationAggregate, ModuleSchemaAggregate } from "../src/modules/index.js";
import { composePlatformPermissionRegistry } from "../src/modules/permissions.js";
const originalNoColor = process.env.NO_COLOR;
afterEach(() => {
if (originalNoColor === undefined) {
delete process.env.NO_COLOR;
} else {
process.env.NO_COLOR = originalNoColor;
}
});
function zeroSchemaAggregate(): ModuleSchemaAggregate {
return Object.freeze({
discoveredModules: Object.freeze([]),
drizzleSchema: Object.freeze({}),
modules: Object.freeze([]),
tables: Object.freeze([]),
});
}
function zeroMigrationAggregate(): ModuleMigrationAggregate {
return Object.freeze({
discoveredModules: Object.freeze([]),
migrations: Object.freeze([]),
modules: Object.freeze([]),
});
}
function noConfigurationDependencies(): DoctorDependencies {
return {
composePermissions: composePlatformPermissionRegistry,
createMigrationDatabase: () => {
throw new Error("database must not be constructed");
},
discoverMigrations: async () => zeroMigrationAggregate(),
discoverModules: async () => Object.freeze([]),
discoverSchemas: async () => zeroSchemaAggregate(),
planMigrations: async () => {
throw new Error("database must not be planned");
},
runtimeSatisfies: () => true,
};
}
describe("Ekklesia Doctor terminal report", () => {
it("renders the real zero-module and no-database shape exactly", async () => {
const report = await diagnoseEkklesia(
{
moduleDiscovery: {
moduleSdkVersion: "0.1.0",
modulesDirectory: "/not-rendered/modules",
platformVersion: "0.1.0",
},
runtimeRange: ">=24.11.0 <25",
runtimeVersion: "24.15.0",
},
noConfigurationDependencies(),
);
expect(formatDoctorReport(report).join("\n")).toBe(`Ekklesia Doctor
Platform
✓ Runtime version supported
Active Node.js satisfies the declared supported range.
Modules
✓ Module discovery complete
0 modules installed
✓ Dependency graph valid
Dependency order is empty.
✓ Permission registry composed
1 permission registered
Data definitions
✓ Schemas validated
0 modules · 0 tables
✓ Migrations validated
0 migrations · checksums valid
PostgreSQL
○ Connection check skipped
DATABASE_URL is not configured.
○ Migration plan skipped
A validated migration inventory and configured PostgreSQL connection are required.
Identity
○ Identity configuration skipped
Core identity schema defines 4 tables (ekklesia_core_account, ekklesia_core_session, ekklesia_core_user, ekklesia_core_verification).
Identity runtime configuration (signing key, base URL, trusted origins) is not set.
Object storage
○ Check unavailable
Core storage integration has not been implemented yet.
Result: READY WITH WARNINGS`);
});
it("does not depend on NO_COLOR or terminal interactivity", async () => {
const report = await diagnoseEkklesia(
{
moduleDiscovery: {
moduleSdkVersion: "0.1.0",
modulesDirectory: "/not-rendered/modules",
platformVersion: "0.1.0",
},
runtimeRange: ">=24.11.0 <25",
runtimeVersion: "24.15.0",
},
noConfigurationDependencies(),
);
const baseline = formatDoctorReport(report);
const originalIsTtyDescriptor = Object.getOwnPropertyDescriptor(process.stdout, "isTTY");
try {
process.env.NO_COLOR = "1";
Object.defineProperty(process.stdout, "isTTY", { configurable: true, value: true });
const interactiveWithoutColor = formatDoctorReport(report);
process.env.NO_COLOR = "";
Object.defineProperty(process.stdout, "isTTY", { configurable: true, value: false });
const nonInteractive = formatDoctorReport(report);
expect(interactiveWithoutColor).toEqual(baseline);
expect(nonInteractive).toEqual(baseline);
expect(interactiveWithoutColor.some((line) => line.includes("\u001B"))).toBe(false);
expect(Object.isFrozen(interactiveWithoutColor)).toBe(true);
} finally {
if (originalIsTtyDescriptor) {
Object.defineProperty(process.stdout, "isTTY", originalIsTtyDescriptor);
} else {
delete (process.stdout as { isTTY?: boolean }).isTTY;
}
}
});
it("never renders secrets from a hostile database exception", async () => {
const hostile =
"postgresql://admin:[email protected]/db SELECT password FROM users /home/me/.env";
const database = Object.freeze({}) as MigrationDatabase;
const dependencies: DoctorDependencies = {
...noConfigurationDependencies(),
createMigrationDatabase: () => database,
planMigrations: async () => {
throw new Error(hostile);
},
};
const report = await diagnoseEkklesia(
{
databaseUrl: "postgresql://another:[email protected]/db",
moduleDiscovery: {
moduleSdkVersion: "0.1.0",
modulesDirectory: "/not-rendered/modules",
platformVersion: "0.1.0",
},
runtimeRange: ">=24.11.0 <25",
runtimeVersion: "24.15.0",
},
dependencies,
);
const output = formatDoctorReport(report).join("\n");
for (const forbidden of [
"admin",
"secret",
"host.invalid",
"SELECT",
"password",
"/home/me",
"postgresql://",
]) {
expect(output).not.toContain(forbidden);
}
});
});